-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for mapl when environment variable BASEDIR is set #229
Bug fix for mapl when environment variable BASEDIR is set #229
Conversation
# for an environment variable with the same name. This | ||
# name is common and used all over the place, and if | ||
# it is set it breaks the mapl build. Unset it here ... | ||
env.unset("BASEDIR") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Sorry about this, @climbfuji. I added that code because users here didn't want to always pass in -DBASEDIR
on the CMake line. I don't mind doing it, but users liked being able to do cmake -B build
and all works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a problem at all, just wondering if we could use a safer name going forward, for example GEOS_BASEDIR or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if/when we go to Spack, we won't need it, so that's nice. Unfortunately, BASEDIR
is pretty much embedded into the foundations of GEOS. Build system, run script, etc.
…pack into feature/mapl_basedir_buildcache_macos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested with ufs-weather-model-static on hera just to be safe.
…pack into feature/mapl_basedir_buildcache_macos
Description
Fixes a problem with
mapl
where the presence of the environment variableBASEDIR
wrecks havoc for the build of the package. This environment variable isn't needed when using spack to buildmapl
and other GEOS packages. It's only needed when using the oldbaselibs
system developed by NASA.Tested with JCSDA/spack-stack#476.